Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] add tests for Python FastAPI header injection #3779

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

juanjux
Copy link
Contributor

@juanjux juanjux commented Jan 7, 2025

Signed-off-by: Juanjo Alvarez [email protected]## Motivation

Changes

Add the endpoints for (Python's) FastAPI header injection that will be released with 2.20.0.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux added the python Pull requests that update Python code label Jan 7, 2025
@juanjux juanjux self-assigned this Jan 7, 2025
Signed-off-by: Juanjo Alvarez <[email protected]>
…DataDog/system-tests into juanjux/python-fastapi-header-injection
@juanjux juanjux marked this pull request as ready for review January 8, 2025 12:09
@juanjux juanjux requested review from a team as code owners January 8, 2025 12:09
@juanjux juanjux requested review from taegyunkim and erikayasuda and removed request for a team January 8, 2025 12:09
@juanjux juanjux merged commit 036d7af into main Jan 8, 2025
92 checks passed
@juanjux juanjux deleted the juanjux/python-fastapi-header-injection branch January 8, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants